Make create_table wait for table

[gordonbondon]

It takes some time to initialize DynamoDB table, and previously I was getting this errors on creation:

Aws::DynamoDB::Errors::ResourceInUseException: Attempt to change a resource which is still in use: Table lock_table_name is being created

or

Aws::DynamoDB::Errors::ResourceNotFoundException: Requested resource not found: Table: lock_table_name not found

Plus I made this call idempotent, allowing to make create_table call on existing tables.

[eredi93]

this method is becoming quite big 😬
can you split it into 3 smaller private methods that then gets called by the create_table method?

something like:

def create_table
  create_ddb_table
  wait_until_ddb_table_exists
  set_ddb_table_ttl
end

private def create_ddb_table
  client.create_table(
    ...
  )
rescue Aws::DynamoDB::Errors::ResourceInUseException => e
  case e.massage
  when "Table already exists: #{table}"
    Marloss.logger.warn("DynamoDB table #{table} already exists")
  else
    raise
  end
end

private def wait_until_ddb_table_exists
  client.wait_until(:table_exists, table_name: table) do |w|
    w.max_attempts = 10
    w.delay = 1
  end
rescue Aws::Waiters::Errors::WaiterFailed => e
  Marloss.logger.error("Failed waiting for initialization of table #{table}")
  raise
end

private def set_ddb_table_ttl
  client.update_time_to_live(
    ...
  )
rescue Aws::DynamoDB::Errors::ValidationException => e
  case e.message
  when "TimeToLive is already enabled"
    Marloss.logger.warn("TTL attribute is already configured for table #{table}")
  else
    raise
  end
end

[gordonbondon]

Easy!

[gordonbondon]

How about keeping create and wait in one method and splitting out ttl?

[eredi93]

that could cause confusion whether the TTL is required or not. I think exposing a simple method would create a better user experience

[gordonbondon]

sounds fair. I've added separate wait function

[eredi93]

👍

[eredi93]

why not splitting the waiting to a separate method as I proposed?

[eredi93]

this begin is not necessary

[gordonbondon]

fixed

[eredi93]

LGTM 👌

[eredi93]

@gordonbondon Thanks you for getting this PR together! 🙇