Respect --no-plugins and --no-scripts option value follow up#1184
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1184 +/- ##
=========================================
Coverage 86.55% 86.55%
- Complexity 58 60 +2
=========================================
Files 4 4
Lines 372 372
=========================================
Hits 322 322
Misses 50 50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
localheinz
changed the title
--no-plugins and --no-scripts option value follow up
localheinz
force-pushed
the
patch-2
branch
2 times, most recently
from
7d09b0b to
c01ddd4
Compare
localheinz
approved these changes
Oct 9, 2023
Member
|
Thank you, @mxr576! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request if a follow up on #1141 where it seems I have made a mistake 🤦♂️ I did not realize that these are option flags therefore their value does not matter... I have just 'blindly" adjusted the original code, run some tests and it seems the fix is working... well, it does not because Composer internally only checks whether these flags are set or not and not their value.
Follows #1141.
Fixes #1130.