Skip to content

Fix: Mark classes as internal#270

Merged
localheinz merged 1 commit into
masterfrom
fix/internal
Dec 17, 2019
Merged

Fix: Mark classes as internal#270
localheinz merged 1 commit into
masterfrom
fix/internal

Conversation

@localheinz

Copy link
Copy Markdown
Member

This PR

  • marks classes as internal to allow modifications without the need for a major release

💁‍♂ Besides, nobody would want to use these classes directly anyway.

@localheinz localheinz added the bug label Dec 17, 2019
@localheinz localheinz self-assigned this Dec 17, 2019
@codecov

codecov Bot commented Dec 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #270   +/-   ##
=======================================
  Coverage        80%    80%           
  Complexity       39     39           
=======================================
  Files             3      3           
  Lines           175    175           
=======================================
  Hits            140    140           
  Misses           35     35
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 88.07% <ø> (ø) 32 <0> (ø) ⬇️
src/Command/SchemaUriResolver.php 0% <ø> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c941335...a50b24e. Read the comment docs.

@localheinz localheinz merged commit e0c91ba into master Dec 17, 2019
@localheinz localheinz deleted the fix/internal branch December 17, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant