docs: Explain the transitive dependency case for no-extraneous-*#347
Merged
scagood merged 4 commits intoeslint-community:masterfrom Sep 26, 2024
Merged
docs: Explain the transitive dependency case for no-extraneous-*#347scagood merged 4 commits intoeslint-community:masterfrom
scagood merged 4 commits intoeslint-community:masterfrom
Conversation
no-extraneous-require will fail when a require is requiring a consistently available package that is not explicitly listed as a direct dependency. This doc change explains why.
Update import doc to match require doc.
scagood
reviewed
Sep 25, 2024
scagood
left a comment
scagood
left a comment
There was a problem hiding this comment.
This looks so much better! Thank you for the PR 😍
scagood
changed the title
Co-authored-by: Sebastian Good <2230835+scagood@users.noreply.github.com>
… available in production installations
DingoEatingFuzz
force-pushed
the
patch-1
branch
from
0c4df40 to
be49f88
Compare
Author
|
Your edits make it read much better! I copied your suggestion to the |
This was referenced Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped into this today and the rule totally makes sense, but I think the docs are missing a slightly pedantic yet still important scenario regarding importing transitive dependencies.