Skip to content

docs: Explain the transitive dependency case for no-extraneous-* #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scagood merged 4 commits into from
Sep 26, 2024
Merged

docs: Explain the transitive dependency case for no-extraneous-* #347

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25a0d61
Explain the transitive dependency case
DingoEatingFuzz Sep 25, 2024
347b0b5
Explain the transitive dependency case
DingoEatingFuzz Sep 25, 2024
e31709b
Rephrase new and existing language
DingoEatingFuzz Sep 26, 2024
be49f88
Call out how transitive dependencies via dev dependencies will not be…
DingoEatingFuzz Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/rules/no-extraneous-import.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

<!-- end auto-generated rule header -->

If an `import` declaration's source is extraneous (it's not written in `package.json`), the program works in local, but will not work after dependencies are re-installed. It will cause troubles to your team/contributors.
If an `import` declaration's source is extraneous (it's not written in `package.json`), the program works in local, but may not work after dependencies are re-installed. It will cause troubles to your team/contributors. If a declaration source is extraneous yet consistently works for you and your team, it may be a transitive dependency (a dependency of a dependency). Transitive dependencies should still be saved as an explicit dependency in `package.json` to avoid the risk of a dependency changing and removing the dependency of a dependency this `import` is relying on.
Comment thread
DingoEatingFuzz marked this conversation as resolved.
Outdated
Comment thread
scagood marked this conversation as resolved.
Outdated

This rule disallows `import` declarations of extraneous modules.

## 📖 Rule Details
Expand Down
3 changes: 2 additions & 1 deletion docs/rules/no-extraneous-require.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

<!-- end auto-generated rule header -->

If a `require()`'s target is extraneous (it's not written in `package.json`), the program works in local, but will not work after dependencies are re-installed. It will cause troubles to your team/contributors.
If a `require()`'s target is extraneous (it's not written in `package.json`), the program works in local, but may not work after dependencies are re-installed. It will cause troubles to your team/contributors. If a target is extraneous yet consistently works for you and your team, it may be a transitive dependency (a dependency of a dependency). Transitive dependencies should still be saved as an explicit dependency in `package.json` to avoid the risk of a dependency changing and removing the dependency of a dependency this `require()` is relying on.

This rule disallows `require()` of extraneous modules.

## 📖 Rule Details
Expand Down
⚡