fix(no-missing-import): Ignore node builtins in package.json imports#346
Merged
aladdin-add merged 1 commit intoeslint-community:masterfrom Oct 9, 2024
Merged
fix(no-missing-import): Ignore node builtins in package.json imports#346aladdin-add merged 1 commit intoeslint-community:masterfrom
imports#346aladdin-add merged 1 commit intoeslint-community:masterfrom
Conversation
1 task
aladdin-add
approved these changes
Oct 9, 2024
This was referenced Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers over
enhanced-resolve's behaviour of throwing unresolved modules, as it cannot resolve builtin node modules.This is done by adding a load of aliases that are effectivly:
{ name: moduleName, alias: false }meaning that enhanced resolve does not throw.