refactor: Improve typescript types and strictness#367
Merged
aladdin-add merged 9 commits intoeslint-community:masterfrom Oct 30, 2024
Merged
refactor: Improve typescript types and strictness#367aladdin-add merged 9 commits intoeslint-community:masterfrom
aladdin-add merged 9 commits intoeslint-community:masterfrom
Conversation
Author
|
I do still need to work on the type tests, I may see if I can steal from #366 😅 |
This comment was marked as resolved.
This comment was marked as resolved.
voxpelli
reviewed
Oct 23, 2024
aladdin-add
changed the title
scagood
force-pushed
the
typescript-war
branch
from
cbc7120 to
98d5fb4
Compare
scagood
changed the title
aladdin-add
approved these changes
Oct 28, 2024
aladdin-add
left a comment
aladdin-add
left a comment
There was a problem hiding this comment.
LGTM. confirmed the generated typings is right. 👍
|
technically it fixes #320. Did you not close it for the subsequent task of adding type tests? 😄 |
|
@voxpelli, @MichaelDeBoey, PTAL. :) |
Member
MichaelDeBoey
left a comment
MichaelDeBoey
left a comment
There was a problem hiding this comment.
This makes me think that we should port the codebase to pure TS at one point in the (near) future 🤔
CC/ @eslint-community/eslint-plugin-node
Author
I am currently in the jsdoc > typescript camp for a few reasons:
Its not that I am not against using typescript, I just find that I prefer jsdoc 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a much stricter tsconfig.
It looks like this does now correctly export the types too.
