feat: support eslint config comments#332
Merged
mdjermanovic merged 2 commits intoeslint:mainfrom Apr 6, 2025
Merged
Conversation
nzakas
reviewed
Apr 1, 2025
nzakas
approved these changes
Apr 4, 2025
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
LGTM, nice work! Would like @mdjermanovic to review before merging.
mdjermanovic
changed the title
applyInlineConfigeslint config comments
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've finished implementing the
applyInlineConfigmethod.For both source code and tests, I referenced JSON and CSS.
I also updated the
configCommentStartregex to correctly recognize inline configs.resolves: #330