Skip to content

chore: fix wrong @fileoverview description#428

Merged
nzakas merged 1 commit intomainfrom
test-replace-strictequal
Jun 20, 2025
Merged

chore: fix wrong @fileoverview description#428
nzakas merged 1 commit intomainfrom
test-replace-strictequal

Conversation

@lumirlumir
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir commented Jun 20, 2025

Prerequisites checklist

What is the purpose of this pull request?

Hello,

In this PR, I've fixed wrong @fileoverview description.


Edit: This PR has been updated to only include a simple description fix instead of adding a test case.

What changes did you make? (Give an overview)

I've fixed wrong @fileoverview description.

Related Issues

Is there anything you'd like reviewers to focus on?

@@ -1,5 +1,5 @@
/**
* @fileoverview Functions to fix up rules to provide missing methods on the `context` object.
* @fileoverview The MarkdownLanguage class.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous description was somewhat incorrect. FYI, CSS Language uses a similar description as well.

https://github.com/eslint/css/blob/main/src/languages/css-language.js#L2

@lumirlumir lumirlumir moved this to Needs Triage in Triage Jun 20, 2025
Comment thread tests/language/markdown-source-code.test.js Outdated
@lumirlumir lumirlumir changed the title test: replace strictEqual with deepStrictEqual for better accuracy test: add deepStrictEqual test for better accuracy Jun 20, 2025
@lumirlumir lumirlumir marked this pull request as draft June 20, 2025 11:16
@lumirlumir lumirlumir changed the title test: add deepStrictEqual test for better accuracy test: add deepStrictEqual tests for better accuracy Jun 20, 2025
@lumirlumir lumirlumir force-pushed the test-replace-strictequal branch from 5e0f5f6 to eb37c13 Compare June 20, 2025 13:57
@lumirlumir lumirlumir changed the title test: add deepStrictEqual tests for better accuracy chore: fix wrong @fileoverview description Jun 20, 2025
@lumirlumir lumirlumir marked this pull request as ready for review June 20, 2025 14:00
Copy link
Copy Markdown
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 2435390 into main Jun 20, 2025
23 checks passed
@nzakas nzakas deleted the test-replace-strictequal branch June 20, 2025 18:48
@github-project-automation github-project-automation Bot moved this from Needs Triage to Complete in Triage Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants