Adding Waveshare ESP32-S3 Touch LCD 2.8C#225
Closed
martinroger wants to merge 2 commits intoesp-arduino-libs:masterfrom
Closed
Adding Waveshare ESP32-S3 Touch LCD 2.8C#225martinroger wants to merge 2 commits intoesp-arduino-libs:masterfrom
martinroger wants to merge 2 commits intoesp-arduino-libs:masterfrom
Conversation
Contributor
Author
|
FYI @Lzw655 I think there is something odd with the version check python script, pre-commit appears to fail on one specific file (both on Github Actions and on my valiant Raspberry Pi) after I moved the library version of `esp_panel_board_supported_conf`` from 1.1.0 to 1.2.0 : Somehow it is perfectly happy with the copies of that same file in all the other example folders. I think I found the issue... third PR attempt incoming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
esp_panel_board_custom_conf.hfile easily with ESP-IDFESP_PANEL_BOARD_SUPPORTED_FILE_VERSIONto 1.2.0 proposedESP_PANEL_VERSIONto 1.0.4 proposed