Support for Waveshare ESP32-S3 Touch LCD 2.8C#226
Closed
martinroger wants to merge 1 commit intoesp-arduino-libs:masterfrom
Closed
Support for Waveshare ESP32-S3 Touch LCD 2.8C#226martinroger wants to merge 1 commit intoesp-arduino-libs:masterfrom
martinroger wants to merge 1 commit intoesp-arduino-libs:masterfrom
Conversation
Collaborator
|
Hi @martinroger, You're so kind! If you're not in a hurry, I'll try to review it this week! |
Contributor
Author
|
Absolutely not in a hurry! |
Lzw655
approved these changes
Jul 13, 2025
Collaborator
Lzw655
left a comment
Lzw655
left a comment
There was a problem hiding this comment.
Hi @martinroger,
This PR is truly perfect. I think there are hardly any areas that need modification. Therefore, I directly took your commit to another PR (since this repository needs to run some tests on the company's internal Gitlab, third - party PRs are usually not merged directly), and then made some minor adjustments along the way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
esp_panel_board_custom_conf.hfile easily with ESP-IDF ( closing ESPIDF : Using custom board with esp_panel_board_custom_conf.h #217 )ESP_PANEL_BOARD_SUPPORTED_FILE_VERSIONto 1.2.0 proposedESP_PANEL_VERSIONto 1.0.4 proposed