Modify GPIO descriptions and add WTS01 sensor config#1525
Open
kellerza wants to merge 2 commits intoesphome:mainfrom
Open
Modify GPIO descriptions and add WTS01 sensor config#1525kellerza wants to merge 2 commits intoesphome:mainfrom
kellerza wants to merge 2 commits intoesphome:mainfrom
Conversation
Updated GPIO pin descriptions and added configuration for WTS01 temperature sensor.
✅ Deploy Preview for esphome-devices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Sonoff THR316 device documentation to generalize GPIO pin descriptions and add an example configuration snippet for using a WTS01 temperature sensor.
Changes:
- Generalize GPIO25/GPIO27 pin descriptions from Dallas-specific wording to generic “Sensor Bus” wording.
- Add a new documentation section with a YAML snippet showing how to wire/configure a WTS01 temperature sensor (UART + sensor power).
Comment on lines
+279
to
+280
| The following yaml enables the [WTS01 sensor](https://esphome.io/components/sensor/wts01/) on the Sonoff THR316 | ||
| and exposes the measured value as `temp`. |
There was a problem hiding this comment.
The text says the WTS01 value is exposed as temp, but the YAML only sets id: temp (which is for internal references) and does not set a name: for the sensor. If the intent is to expose it in Home Assistant, add an explicit name: (and consider adjusting the wording to avoid implying the entity name comes from the id).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated GPIO pin descriptions and added configuration for WTS01 temperature sensor.
Brief description of the changes
Type of changes
Checklist:
The only exceptions are
!secret wifi_ssidand!secret wifi_password.wifiorethernetblock has no static / manual ip address specified.A more involved example can be provided in a separate configuration block.