Skip to content

ci(actions): Replace changed-files#11130

Merged
me-no-dev merged 1 commit into
espressif:masterfrom
lucasssvaz:fix/changed-files
Mar 17, 2025
Merged

ci(actions): Replace changed-files#11130
me-no-dev merged 1 commit into
espressif:masterfrom
lucasssvaz:fix/changed-files

Conversation

@lucasssvaz

@lucasssvaz lucasssvaz commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description of Change

Replace compromised changed-files with native solutions

Tests scenarios

CI, local and fork.

Related Issues

Closes #11127

@lucasssvaz lucasssvaz added the Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. label Mar 17, 2025
@lucasssvaz lucasssvaz self-assigned this Mar 17, 2025
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 89be464

@Jason2866 Jason2866 mentioned this pull request Mar 17, 2025
Closed
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Mar 17, 2025
@me-no-dev me-no-dev merged commit ba2ab1e into espressif:master Mar 17, 2025
@sammashar56

sammashar56 commented Mar 18, 2025

Copy link
Copy Markdown

Hey all getting errors when installing this on my mac to test the nodemcu esp -32, any support please?

@lucasssvaz lucasssvaz deleted the fix/changed-files branch March 19, 2025 13:18
lucasssvaz added a commit to lucasssvaz/arduino-esp32 that referenced this pull request Mar 19, 2025
@lucasssvaz
Revert "ci(actions): Replace changed-files (espressif#11130)"
ea4be13 
This reverts commit ba2ab1e.
lucasssvaz added a commit that referenced this pull request Mar 24, 2025
@lucasssvaz
Revert "ci(actions): Replace changed-files (#11130)"
512ffd6 
This reverts commit ba2ab1e.
me-no-dev pushed a commit that referenced this pull request Mar 27, 2025
@lucasssvaz
ci(workflows): Lock actions to commits and improve readability (#11147)
caa5971 
* Revert "ci(actions): Replace changed-files (#11130)"

This reverts commit ba2ab1e.

* ci(workflows): Lock actions to commits and improve readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@SuGlider SuGlider Awaiting requested review from SuGlider

Assignees

@lucasssvaz lucasssvaz

Labels

Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

arduino-esp32 is using a compromised tj-actions/changed-files GitHub action (CVE-2025-30066)

4 participants

@lucasssvaz @sammashar56 @me-no-dev @P-R-O-C-H-Y
⚡