Skip to content

ESP_LVGL_PORT lvgl_port_flush_rgb_vsync_ready_callback in IRAM (BSP-639) #515

@mattmatt206

Description

@mattmatt206

Related area

ESP_LVGL_PORT

Hardware specification

ESP32S3

Is your feature request related to a problem?

when LCD_RGB_ISR_IRAM_SAFE is enabled in SDK config, the following error is given:
lcd_panel.rgb: esp_lcd_rgb_panel_register_event_callbacks(397): on_frame_buf_complete callback not in IRAM
ESP_ERROR_CHECK failed: esp_err_t 0x102 (ESP_ERR_INVALID_ARG) at 0x420405fc

Describe the solution you'd like

add IRAM attribute to vsync ready callback so can be used with LCD_RGB_ISR_IRAM_SAFE enabled

proposed change
line 68 (esp_lvgl_port_disp.c)
static bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx);
to
static IRAM_ATTR bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx);

and
line 446 (esp_lvgl_port_disp.c)
static bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx)
to
static IRAM_ATTR bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx)

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions