Skip to content

Add RGB support for esp_lv_port (BSP-428)#266

Closed
espressif2022 wants to merge 11 commits intoespressif:masterfrom
espressif2022:feature/lv_port_RGB
Closed

Add RGB support for esp_lv_port (BSP-428)#266
espressif2022 wants to merge 11 commits intoespressif:masterfrom
espressif2022:feature/lv_port_RGB

Conversation

@espressif2022
Copy link
Copy Markdown
Contributor

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

1: Delete lv_port from esp32_s3_lcd_ev_board
2: Add RGB flag for esp_lv_port

@github-actions github-actions bot changed the title Add RGB support for esp_lv_port Add RGB support for esp_lv_port (BSP-428) Jan 2, 2024
Copy link
Copy Markdown
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espressif2022 Thank you very much for this PR. I am sorry to late reaction. I read changes lot of times (not too deep), but I still haven't got time for test. I would like to add it to new LVGL port 2.0 (with LVGL9).

I have only one comment now. I don't like the changes in main header file. I hoped that it every callbacks will be solved inside. I don't know, if is it possible, but I hope so. I will try to understand more later and I will try to use this draft for implementation into new LVGL port :-)

Thank you very much!

@espressif2022
Copy link
Copy Markdown
Contributor Author

@espressif2022 Thank you very much for this PR. I am sorry to late reaction. I read changes lot of times (not too deep), but I still haven't got time for test. I would like to add it to new LVGL port 2.0 (with LVGL9).

I have only one comment now. I don't like the changes in main header file. I hoped that it every callbacks will be solved inside. I don't know, if is it possible, but I hope so. I will try to understand more later and I will try to use this draft for implementation into new LVGL port :-)

Thank you very much!

I'll think about it. I haven't dealt with this recently, and maybe after the holiday.
The RGB flush callback was a bit tricky; we didn't integrate it at that time. I'll also take a look at the changes in the LVGL V9 flush callback.

@VojtechBartoska VojtechBartoska added the Area: LVGL related to LVGL and LVGL port label Mar 13, 2024
@espressif2022 espressif2022 deleted the feature/lv_port_RGB branch May 30, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: LVGL related to LVGL and LVGL port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants