Merged
Conversation
2 tasks
tore-espressif
force-pushed
the
fix/pedantic_p4_bsp
branch
from
5683121 to
8254753
Compare
espzav
approved these changes
Nov 1, 2024
Collaborator
espzav
left a comment
espzav
left a comment
There was a problem hiding this comment.
@tore-espressif thank you for the fix! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
Hot fix for pedantic builds with P4_ev_board BSP
Eg. failed job here https://github.com/espressif/idf-extra-components/actions/runs/11603657651/job/32311078844#step:5:30731
We should prioritize #51 to prevent this in the future