Fix: knob loses diff event (BSP-592)#450
Merged
espzav merged 5 commits intoespressif:masterfrom Jan 28, 2025
Merged
Conversation
github-actions
bot
changed the title
espzav
reviewed
Dec 4, 2024
espzav
reviewed
Jan 7, 2025
Collaborator
espzav
left a comment
espzav
left a comment
There was a problem hiding this comment.
@espressif2022 Thank you for update. I will test it today or tomorrow with HW :-)
espzav
approved these changes
Jan 14, 2025
Collaborator
espzav
left a comment
espzav
left a comment
There was a problem hiding this comment.
@espressif2022 Thank you for changes. LGTM
Please, squash commits and update branch before merging.
Collaborator
|
@espressif2022 Could you please add a note to CHANGELOG.md too? |
espzav
force-pushed
the
fixed/encode_read
branch
from
62c5532 to
6d19e7b
Compare
espzav
force-pushed
the
fixed/encode_read
branch
from
6d19e7b to
2d89c12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
1: The new component of the
knobwill clear the flag of knob->event, so we addcount_valuefor conditional checks.