Conversation
Still needs testing plus validation
Reflects addition of row override, opening door to ssd1680 support
|
|
tore-espressif
left a comment
tore-espressif
left a comment
There was a problem hiding this comment.
@malachib thank you for the PR!
Would it be better if we stored real number of rows in epaper_panel->_rows?
| #define SSD1681_CMD_OUTPUT_CTRL 0x01 | ||
| #define SSD1681_PARAM_OUTPUT_CTRL ((uint8_t[]) {0xc7, 0x00, 0x00}) | ||
| // Chipset wants (total row count - 1) i.e. 250 rows = 249 here | ||
| #define SSD1681_PARAM_OUTPUT_CTRL(rows) ((uint8_t[]) {(rows) & 0xFF, (rows) >> 8, 0x00}) |
There was a problem hiding this comment.
| #define SSD1681_PARAM_OUTPUT_CTRL(rows) ((uint8_t[]) {(rows) & 0xFF, (rows) >> 8, 0x00}) | |
| #define SSD1681_PARAM_OUTPUT_CTRL(rows) ((uint8_t[]) {(rows - 1) & 0xFF, (rows - 1) >> 8, 0x00}) |
| (epaper_ssd1681_conf->rows - 1) : (SSD1681_EPD_1IN54_V2_HEIGHT - 1); | ||
| if(epaper_panel->_rows != (SSD1681_EPD_1IN54_V2_HEIGHT - 1) && |
There was a problem hiding this comment.
| (epaper_ssd1681_conf->rows - 1) : (SSD1681_EPD_1IN54_V2_HEIGHT - 1); | |
| if(epaper_panel->_rows != (SSD1681_EPD_1IN54_V2_HEIGHT - 1) && | |
| (epaper_ssd1681_conf->rows) : (SSD1681_EPD_1IN54_V2_HEIGHT); | |
| if(epaper_panel->_rows != (SSD1681_EPD_1IN54_V2_HEIGHT) && |
|
Thank you too for providing the ssd1681 in the first place! I am open to your suggestion. I treated rows as precalculated as an optimization. Subtracts are about as fast as it gets though... Certainly the code is clearer the way you suggest. |
|
Hi @malachib and @tore-espressif , someone make more changes and new features in the PR #612, do you agree to close this PR and continue in the new one? |
|
I agree. Somehow I never even knew you suggested those changes @tore-espressif , my apologies |
4 participants
ESP-BSP Pull Request checklist
Change description
Added row override so that ssd1680 may also be used