fix(korvo_2): Fix I2C master transmission issue by adding glitch filtering (BSP-663)#554
Merged
espzav merged 1 commit intoespressif:masterfrom Apr 2, 2025
Conversation
|
linxu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
espzav
approved these changes
Apr 2, 2025
Collaborator
espzav
left a comment
There was a problem hiding this comment.
@PumpkinLin314 Thank you for this fix. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
I found that when using the esp32_s3_korvo_2 v3.0.1 BSP component, the I2C bus sometimes hangs (I2C master transmission gets stuck, triggering the task watchdog).
This issue can be reproduced using esp-bsp/examples/audio with IDF release/v5.4 or master.
As a workaround, I discovered that configuring
glitch_ignore_cntin the I2C initialization structure helps filter out glitches and prevent the issue.