fix(lcd_touch): Add a default I2C clock speed to the configuration macro#744
Merged
fix(lcd_touch): Add a default I2C clock speed to the configuration macro#744
Conversation
Test Results0 tests 0 ✅ 10s ⏱️ Results for commit 5a39b90. ♻️ This comment has been updated with latest results. |
espzav
reviewed
Mar 24, 2026
espzav
reviewed
Mar 25, 2026
Collaborator
espzav
left a comment
espzav
left a comment
There was a problem hiding this comment.
I am not sure, but I think we should increase minimum IDF version to 5.2 for all related components. Because this I2C param was introduced in IDF 5.2
PetrESP
force-pushed
the
petr/fix/i2c_config_macro
branch
from
7f2cb5a to
d639e64
Compare
Collaborator
Author
|
@espzav I've realized that we don't even test lower versions than 5.2 (we can't make sure that they even work) so I think that we can bump all components to at least 5.2. |
PetrESP
force-pushed
the
petr/fix/i2c_config_macro
branch
from
d639e64 to
4246252
Compare
espzav
reviewed
Mar 26, 2026
PetrESP
force-pushed
the
petr/fix/i2c_config_macro
branch
from
4246252 to
ee3815c
Compare
PetrESP
force-pushed
the
petr/fix/i2c_config_macro
branch
from
ee3815c to
5a39b90
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
Added default assignment to
scl_speed_hzin all configuration macros for LCD touch controllersRelates to #743