[3.4] Upgrade grpc-go to 1.29.1 and Backport "Introduce grpc-1.30+ compatible client/v3/naming API."#16795
Merged
Conversation
chaochn47
force-pushed
the
release-3.4-grpc-update
branch
2 times, most recently
from
f3bef24 to
459b3de
Compare
ahrtr
changed the title
ahrtr
changed the title
ahrtr
changed the title
Member
Author
|
Kindly ping @fuweid for a second eye to review it~ I updated the package path of naming and test package during cherry-pick.. Other than that, everything should be the same as the backported PRs. |
chaochn47
force-pushed
the
release-3.4-grpc-update
branch
from
459b3de to
3298840
Compare
fuweid
reviewed
Oct 19, 2023
This is not yet implementation, just API and tests to be filled with implementation in next CLs, tracked by: etcd-io#12652 We propose here 3 packages: - clientv3/naming/endpoints -> That is abstraction layer over etcd that allows to write, read & watch Endpoints information. It's independent from GRPC API. It hides the storage details. - clientv3/naming/endpoints/internal -> That contains the grpc's compatible Update class to preserve the internal JSON mashalling format. - clientv3/naming/resolver -> That implements the GRPC resolver API, such that etcd can be used for connection.Dial in grpc. Please see the grpc_naming.md document changes & grpcproxy/cluster.go new integration, to see how the new abstractions work. Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
release-3.4-grpc-update
branch
from
3298840 to
6c0e4d9
Compare
Member
Author
|
ahrtr
approved these changes
Oct 20, 2023
Member
|
ping @jmhbnz @serathius @wenjiaswe |
jmhbnz
approved these changes
Oct 22, 2023
jmhbnz
left a comment
jmhbnz
left a comment
Member
There was a problem hiding this comment.
LGTM - Just a question about the old test shell script below.
serathius
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #16740
Backport #12397 and #12614 as the first step..
Note: https://etcd.io/docs/v3.4/dev-guide/grpc_naming/ doc needs to be reflected before #16751 is cut.
This will upgrade gRPC to v1.29.1 and naming API change.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.