Skip to content

Regression in 0.16: Client (and Channel) no longer Sync #109

@yotamofek

Description

@yotamofek

#98 has caused a regression in the sense that Client no longer implements Sync (while in all previous versions, AFAICT, it did).

The problem lies in the CustomChannel variant of Channel (this type alias). BoxCloneService does not implement Sync, unlike tower's BoxService which does (because it uses a SyncWrapper, which can't be used in the BoxCloneService since cloning requires accessing the underlying object via a shared ref, which SyncWrapper disallows).

Not sure what the easiest way to solve this is, but I do think making Client Sync is important.

(thank you to everyone working and contributing to this crate!)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions