1099 miner DAG pre-generation fix#212
Merged
iquidus merged 3 commits intoetclabscore:masterfrom Oct 15, 2020
Merged
Conversation
Contributor
|
Is there an existing test for this issue? Is it possible to add one? Desirable to? |
meowsbits
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with pre-generation in which a miner would pre-generate
epoch + 1always. This is correct behaviour with the exception of the activation of 1099, in which the miner should pre-generate(epoch+1) / 2.This PR adds additional logic to properly handle the activation of ecip-1099.