fix(mypy): _Singleton metaclass typing#1888
Merged
iamdefinitelyahuman merged 6 commits intomasterfrom Jun 11, 2025
Merged
Conversation
counterintuitively, when you supply type hints for a metaclass' call method, it breaks typing for the created instances which all resolve to `Any` This PR allows all singleton-based classes to type correctly.
iamdefinitelyahuman
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
counterintuitively, when you supply type hints for a metaclass' call method, it breaks typing for the created instances which all resolve to the
__call__method's return type (currentlyAny)This PR allows all singleton-based classes to type correctly.
What I did
Related issue: #
How I did it
How to verify it
clone it and mouseover the instances in your IDE
Checklist