Call getabi in Contract.from_explorer when getsourcecode fails#462
Merged
iamdefinitelyahuman merged 3 commits intomasterfrom Apr 29, 2020
Merged
Call getabi in Contract.from_explorer when getsourcecode fails#462iamdefinitelyahuman merged 3 commits intomasterfrom
getabi in Contract.from_explorer when getsourcecode fails#462iamdefinitelyahuman merged 3 commits intomasterfrom
Conversation
etherscan's `getsourcecode` API endpoint sometimes does not return verified source, but an ABI is still available from `getabi`. When the first call fails, a 2nd call is made to `getabi` to see if a Contract object can be generated with limited functionality, rather than raising.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Closes #451
How to verify it
Run tests.