Cmd settings to config#501
Merged
iamdefinitelyahuman merged 15 commits intoeth-brownie:masterfrom May 9, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 88.35% 88.44% +0.09%
==========================================
Files 56 56
Lines 6104 6138 +34
Branches 1348 1355 +7
==========================================
+ Hits 5393 5429 +36
+ Misses 489 485 -4
- Partials 222 224 +2
Continue to review full report at Codecov.
|
Member
|
Rebasing in #503 should fix the failing tests. |
Accepts a unit as string and will return a Fixed number converted to the desired unit type
Project specific cmd_settings for ganache-cli new params: --time, --blockTime, --defaultBalanceEther loading a project will update the network settings with project specific settings
- better validation of cmd_settings with error handling - added block_time() to Rpc to get the time in seconds between blocks if specified - added support for --time parameter
added brownie-config.yaml for test project tests to verify that project specific configs update networks
matnad
force-pushed
the
cmd_settings-to-config
branch
from
8626ef6 to
90fca4b
Compare
No way to reliably query it from an attached instance
will only copy the brownie-config.yaml file when needed will now properly open, close and reset the network
Member
iamdefinitelyahuman
left a comment
iamdefinitelyahuman
left a comment
There was a problem hiding this comment.
Looking good overall, a few things to address and a couple questions. Thanks for your work on this!
replace shutil.copy with yaml.dump and dump the config string into the project root testprojectconfig fixture no longer necessary, additional logic moved to settings_proj fixture
better messages and Brownie specific classes for warning changed type checking to isinstance
changed ValueError to TypeError
add "cmd_settings: {}" to default-config.yaml to indicate that these can be specified
iamdefinitelyahuman
requested changes
May 8, 2020
Member
iamdefinitelyahuman
left a comment
iamdefinitelyahuman
left a comment
There was a problem hiding this comment.
Looks great! Just a few minor things.
- removed test file cleanup
- changed default cmd_settings from {} to null
- made _recursive_update null-safe
- replaced yaml.load with yaml.safe_load
- moved yield outside load context
- improved import statements in test_wei.py
iamdefinitelyahuman
approved these changes
May 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Exposed
block_time,default_balanceandtimeganache-cli parametersAdded cmd_settings to project config file
Added Wei.to() to convert wei to other units
Related issue: #486
How I did it
Project settings update network settings on project load
Wei.to() operates with Brownie's Fixed class
How to verify it
Checklist