Merged
Conversation
matnad
requested changes
Jun 1, 2020
Collaborator
matnad
left a comment
matnad
left a comment
There was a problem hiding this comment.
Lgtm except a minor doc detail, thanks for this feature!
iamdefinitelyahuman
force-pushed
the
feat-mnemonics
branch
from
cb93615 to
bd09f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add support for seed phrases.
Closes #334
How I did it
Accounts.from_mnemonicmethod, that relies oneth_accountto do the heavy lifting.Accounts.addnetwork-config.yamlandganache-cliI also updated the docstring format in
Accountsso everything is consistent.How to verify it
Run tests. I added a few new cases.
Checklist