Skip to content

More expressive exception on stale fork#598

Merged
iamdefinitelyahuman merged 3 commits intomasterfrom
feat-fork-middleware
Jun 3, 2020
Merged

More expressive exception on stale fork#598
iamdefinitelyahuman merged 3 commits intomasterfrom
feat-fork-middleware

Conversation

@iamdefinitelyahuman
Copy link
Copy Markdown
Member

@iamdefinitelyahuman iamdefinitelyahuman commented Jun 3, 2020

What I did

Raise a more expressive exception when a forked dev environment stops working from a lack of archival state.

Closes #573

How I did it

Middleware!!!

How to verify it

Run the tests.

@iamdefinitelyahuman iamdefinitelyahuman force-pushed the feat-fork-middleware branch 2 times, most recently from 7fd0a9e to 5b99395 Compare June 3, 2020 19:57
@iamdefinitelyahuman iamdefinitelyahuman marked this pull request as ready for review June 3, 2020 21:23
Copy link
Copy Markdown
Collaborator

@matnad matnad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@iamdefinitelyahuman iamdefinitelyahuman merged commit 3a50fef into master Jun 3, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-fork-middleware branch June 3, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors from no archival state can be confusing

2 participants