Fix repeated alerts by using type instead of instanceof

[tbrent]

What I did

Fix repeated alerts

How I did it

Used type instead of instanceof, because bool is a subclass of int in python.

How to verify it

It's a small change. Also automated tests should pickup if this is broken.

Checklist

• I have confirmed that my PR passes all linting checks
• I have included test cases
• I have updated the documentation
• [✅] I have added an entry to the changelog

[iamdefinitelyahuman]

Thanks for your contribution, and good catch on the bug 🙏 One nitpick and then I think we can include this in the 1.9.0 release today or tomorrow.

More generally - the alert functionality was implemented quite a while ago. If you have any feedback or ideas for how it can be improved based on your use case, I'd love to hear. I'm available on Gitter or Telegram with the same handle as I use on Github.

[iamdefinitelyahuman]

It's more verbose, but I think preferable to use isinstance(repeat, int) and not isinstance(repeat, bool) - because Wei is an int subclass and commonly used for return values, I can imagine a situation where the user is trying to set an alert with that type.

[tbrent]

Makes sense. Updated to reflect this.

I'll keep a lookout for possible improvements while we apply our usecase to it 👍

[iamdefinitelyahuman]

Thanks!