fix: return actual call during call-as-tx#614
Merged
iamdefinitelyahuman merged 1 commit intomasterfrom Jun 6, 2020
Merged
Conversation
matnad
approved these changes
Jun 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When coverage evaluation is active, return the actual result of
eth_call, rather thantx.return_valueThis fixes an edge case where if
rpc.sleepwas called after the last transaction, and the call relies onblock.timestamp, the act of performing a transaction can alter the result.How to verify it
Run tests.