Run calls as transactions when catching dev revert comment#659
Merged
iamdefinitelyahuman merged 1 commit intomasterfrom Jul 4, 2020
Merged
Run calls as transactions when catching dev revert comment#659iamdefinitelyahuman merged 1 commit intomasterfrom
iamdefinitelyahuman merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When using
brownie.revertsto catch a dev revert comment, perform all calls as transactions. This fixes an issue where sometimes it is impossible to assign a revert comment to a failed call.How to verify it
Run tests.