Handle incomplete solc source map#676
Merged
iamdefinitelyahuman merged 1 commit intomasterfrom Jul 9, 2020
Merged
Conversation
iamdefinitelyahuman
force-pushed
the
fix-missing-sourcemap
branch
from
2631f11 to
d82c046
Compare
iamdefinitelyahuman
force-pushed
the
fix-missing-sourcemap
branch
from
d82c046 to
7cef594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
During compilation, extend
pcMapif solidity does not provide a long enoughsourceMap.I'm still investigating the cause, but I've managed to produce the following minimal example that produces a
sourceMapthat is 7 instructions too short: https://gist.github.com/iamdefinitelyahuman/a6c658acb7e83371ecf730ebf6f8814dHow to verify it
Run tests.