Skip to content

check for getitem/call before showing open paren hints#694

Merged
iamdefinitelyahuman merged 1 commit intomasterfrom
fix-console-hints
Jul 20, 2020
Merged

check for getitem/call before showing open paren hints#694
iamdefinitelyahuman merged 1 commit intomasterfrom
fix-console-hints

Conversation

@iamdefinitelyahuman
Copy link
Copy Markdown
Member

What I did

Check validity of open bracket when finding type hints / completions.

How I did it

  • For ( check that the object has a __call__ method
  • For [ check that the object has a __getitem__ method

How to verify it

Try it in the console.

@iamdefinitelyahuman iamdefinitelyahuman merged commit d247a7b into master Jul 20, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-console-hints branch July 20, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant