Include vyper library in installed versions after installing vyper#803
Merged
iamdefinitelyahuman merged 2 commits intomasterfrom Oct 11, 2020
Merged
Include vyper library in installed versions after installing vyper#803iamdefinitelyahuman merged 2 commits intomasterfrom
iamdefinitelyahuman merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix an issue where after installing vyper, the
vyperlibrary version was not included in the installed versions.This bug was first discovered by @pengiundev here - https://github.com/curvefi/curve-dao-contracts/pull/45/checks?check_run_id=1236469559
How I did it
Call to the local
_get_vyper_version_listinstead ofvvm.get_installed_vyper_versionsafter installing.