Skip to content

feat: decode ds-note events#985

Merged
iamdefinitelyahuman merged 3 commits intoeth-brownie:masterfrom
banteg:feat/ds-note
Mar 13, 2021
Merged

feat: decode ds-note events#985
iamdefinitelyahuman merged 3 commits intoeth-brownie:masterfrom
banteg:feat/ds-note

Conversation

@banteg
Copy link
Copy Markdown
Collaborator

@banteg banteg commented Mar 11, 2021

What I did

Added support to decode different variants of ds-note events, commonly used across MakerDAO ecosystem.

Screen Shot 2021-03-11 at 20 08 09

Tested with:

Related issue: #

How I did it

How to verify it

network.connect('mainnet')
tx = chain.get_transaction('0x7d5799a3622477847731d22ddd8d38031a949159446a727b3e4e7542ad558806')
tx.info()

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

@iamdefinitelyahuman iamdefinitelyahuman self-requested a review March 11, 2021 23:52
Copy link
Copy Markdown
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants