Skip to content

chore: dep upgrade#921

Merged
SamTV12345 merged 2 commits intomainfrom
feature/dep-upgrades
Apr 13, 2026
Merged

chore: dep upgrade#921
SamTV12345 merged 2 commits intomainfrom
feature/dep-upgrades

Conversation

@SamTV12345
Copy link
Copy Markdown
Member

No description provided.

@qodo-free-for-open-source-projects
Copy link
Copy Markdown

Review Summary by Qodo

Replace ESLint with Oxlint and upgrade dev dependencies
✨ Enhancement

Grey Divider

Walkthroughs

Description
• Replaced ESLint with Oxlint for faster linting
• Added Oxfmt for code formatting with new npm scripts
• Updated multiple dev dependencies to latest versions
• Upgraded TypeScript from 5.9.2 to 6.0.2
Diagram
flowchart LR
  A["ESLint + plugins"] -->|"replaced by"| B["Oxlint + Oxfmt"]
  C["Dev Dependencies"] -->|"upgraded"| D["Latest versions"]
  E["TypeScript 5.9.2"] -->|"upgraded to"| F["TypeScript 6.0.2"]
  G["npm scripts"] -->|"updated"| H["lint, format scripts"]
Loading

Grey Divider

File Changes

1. package.json Dependencies +16/-15

Replace ESLint with Oxlint and update dependencies

• Replaced ESLint and related plugins with Oxlint and Oxfmt
• Updated lint scripts to use oxlint instead of eslint
• Added new format and format:check scripts for code formatting
• Upgraded dev dependencies including TypeScript (5.9.2 → 6.0.2), Rollup (4.59.0 → 4.60.1), mysql2
 (3.20.0 → 3.22.0), and type definitions
• Updated testcontainers (11.13.0 → 11.14.0) and vitest (4.1.3 → 4.1.4)

package.json


2. pnpm-lock.yaml Dependencies +850/-3028

Update lock file for new dependencies

• Updated lock file to reflect all dependency version changes
• Removed ESLint and eslint-plugin-import dependency trees
• Added Oxlint and Oxfmt dependency trees

pnpm-lock.yaml


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects
Copy link
Copy Markdown

qodo-free-for-open-source-projects Bot commented Apr 13, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Node engine mismatch🐞
Description
package.json declares Node ">=22.0.0" but the newly added dev tools (oxlint/oxfmt) require Node
"^20.19.0 || >=22.12.0", leaving Node 22.0.0–22.11.x as 'supported' by the repo but unsupported by
required lint/format tooling.
Code

package.json[R42-43]

+    "oxfmt": "^0.45.0",
+    "oxlint": "^1.60.0",
Evidence
The PR adds oxlint/oxfmt and makes them part of the repo’s scripts, but those packages declare
stricter Node engine constraints than the repo’s own engines field, creating an inconsistent
supported Node range for contributors/CI that run lint/format.

package.json[41-46]
package.json[78-86]
package.json[98-100]
pnpm-lock.yaml[1735-1743]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`package.json` advertises `engines.node: ">=22.0.0"`, but newly introduced tooling (`oxlint`, `oxfmt`) declares `engines.node: "^20.19.0 || >=22.12.0"`. This leaves a gap where Node `22.0.0`–`22.11.x` is allowed by the repo but not by the tools used in `pnpm run lint` / `pnpm run format`.
### Issue Context
- `oxlint`/`oxfmt` are now part of the default dev workflow (`lint`, `lint:fix`, `format`, `format:check`).
- Their `engines` constraints should be reflected in the repo’s declared Node support.
### Fix Focus Areas
- package.json[98-100]
### Suggested fix
Update `package.json` to align the `engines.node` range with the tools, for example:
- `"node": "^20.19.0 || >=22.12.0"`
Optionally, also ensure CI uses a Node version that satisfies this range (if CI is intended to run lint/format or dev tooling).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@SamTV12345 SamTV12345 merged commit bc64710 into main Apr 13, 2026
11 checks passed
@SamTV12345 SamTV12345 deleted the feature/dep-upgrades branch April 13, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant