Fix: relax Node engine from >=22.22.0 to >=18.0.0#930
Merged
JohnMcLear merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
The engine requirement was set to an unreleased Node version (22.22.0). CI already tests and passes on Node 20. Etherpad supports Node >=18. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Review Summary by QodoRelax Node engine requirement to >=18.0.0
WalkthroughsDescription• Relax Node engine requirement from unreleased 22.22.0 to 18.0.0 • Aligns with actual CI testing on Node 20 and documented support • Fixes overly restrictive version constraint in package.json Diagramflowchart LR
A["package.json<br/>Node engine: >=22.22.0"] -- "Update to supported version" --> B["package.json<br/>Node engine: >=18.0.0"]
File Changes1. package.json
|
Code Review by Qodo
|
| ], | ||
| "engines": { | ||
| "node": ">=22.22.0" | ||
| "node": ">=18.0.0" |
There was a problem hiding this comment.
1. Ci tests wrong node 🐞 Bug ☼ Reliability
The PR relaxes the supported Node version to ">=18.0.0", but CI is still pinned to Node 22.22.0, so the declared support range is not validated and the workflow may fail or produce artifacts untested on the supported versions.
Agent Prompt
### Issue description
The repo's CI workflow is pinned to a Node version that does not reflect the package's declared engine range after this PR.
### Issue Context
`package.json` now declares `engines.node: ">=18.0.0"`, but `.github/workflows/ci.yml` still runs CI on Node `22.22.0`.
### Fix Focus Areas
- package.json[142-144]
- .github/workflows/ci.yml[15-27]
### Suggested fix
- Update `.github/workflows/ci.yml` to test on supported versions (at minimum Node 18, and optionally also Node 20) via a matrix, or pin to an appropriate LTS version consistent with the engine policy.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine requirement was set to
>=22.22.0(an unreleased Node version). CI tests pass on Node 20, and Etherpad supports Node >=18.Found by Qodo review on ether/etherpad#7516.
🤖 Generated with Claude Code