engine: add -38005 error codes in engine_newPayloadV2, engine_getPayloadV2 and engine_forkchoiceUpdatedV2 openrpc methods#780
Open
swastik7805 wants to merge 1 commit intoethereum:mainfrom
Conversation
engine_newPayloadV2, engine_getPayloadV2 and engine_forkchoiceUpdatedV2 openrpc methodsengine_newPayloadV2, engine_getPayloadV2 and engine_forkchoiceUpdatedV2 openrpc methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #776
Fix: Add
-38005Error Code to V2 Engine Method SpecsProblem
engine_forkchoiceUpdatedV2,engine_newPayloadV2, andengine_getPayloadV2are missing the-38005(Unsupported fork) error declaration in their OpenRPC YAML definitions.As Per
cancun.md,these methods must return
-38005when the payload orpayloadAttributestimestamp is >= the Cancun activation timestamp. The Markdown spec is correct but the YAML schema does not reflect this.Changes
forkchoice.yaml— added-38005toengine_forkchoiceUpdatedV2payload.yaml— added-38005toengine_newPayloadV2payload.yaml— added-38005toengine_getPayloadV2Fix
References
cancun.md— Update the methods of previous forksforkchoice.yaml#L45payload.yaml#L64payload.yaml#L316@MysticRyuujin please review