Skip to content
This repository was archived by the owner on Oct 1, 2021. It is now read-only.
This repository was archived by the owner on Oct 1, 2021. It is now read-only.

Instantiating ProviderBridge sets an interval that hangs your node process #1

@alcuadrado

Description

@alcuadrado

ProvideBridge's constructor sets up an interval here that is impossible to stop and doesn't let node processes finish.

Running this script in node is enough to reproduce the problem:

const ProviderBridge = require('ethers-web3-bridge');
new ProviderBridge();

The expected behavior is that the process finishes right after instantiating ProviderBridge, but it never does.

This could be fixed by adding some method to clear that interval, but IMO that would cripple ProviderBridge's API, as it won't be usable in a fire-and-forget scenario.

But I don't see a clear need for having that interval, can't the address be updated right after setting the signer here.

There's also this functionality, which may return an outdated address if the proposed change is implemented, but that's already happening.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions