Skip to content

Close #85 #112, Go mod round2#121

Merged
ChihChengLiang merged 12 commits into
ethresearch:masterfrom
ChihChengLiang:go-mod-round2
Dec 4, 2018
Merged

Close #85 #112, Go mod round2#121
ChihChengLiang merged 12 commits into
ethresearch:masterfrom
ChihChengLiang:go-mod-round2

Conversation

@ChihChengLiang

@ChihChengLiang ChihChengLiang commented Dec 3, 2018

Copy link
Copy Markdown
Collaborator

Note

  • For future module update, use make update-go-mod

What was wrong?

How was it fixed?

  • This command gets the package with the latest commit on master branch go get -v github.com/libp2p/go-libp2p-crypto@master.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@ChihChengLiang ChihChengLiang mentioned this pull request Dec 3, 2018
@ChihChengLiang

Copy link
Copy Markdown
Collaborator Author

@NIC619 This works now, also I think we can remove gx completely.

@ChihChengLiang ChihChengLiang changed the title Go mod round2 Close #85, Go mod round2 Dec 4, 2018
@ChihChengLiang ChihChengLiang changed the title Close #85, Go mod round2 Close #85 #112, Go mod round2 Dec 4, 2018
@ChihChengLiang

Copy link
Copy Markdown
Collaborator Author

@mhchia @NIC619 The focus of the review is whether the new setup works on your environments.

@NIC619 NIC619 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe also update the README file?

Comment thread Makefile

update-go-mod:
GO111MODULE=on go mod download && go mod tidy

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove the gx related commands in Makefile.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do those in #125 for better review experience.

@ChihChengLiang

Copy link
Copy Markdown
Collaborator Author

@NIC619 Thanks for reviewing. After some trying, I feel it's better to update README.md after #127.

@mhchia mhchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and it works well! Great work:)

@ChihChengLiang ChihChengLiang merged commit 97121f5 into ethresearch:master Dec 4, 2018
@ChihChengLiang

Copy link
Copy Markdown
Collaborator Author

Thank you @mhchia & @NIC619 for reviewing ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants