Close #85 #112, Go mod round2#121
Merged
Merged
Conversation
Closed
Collaborator
Author
|
@NIC619 This works now, also I think we can remove gx completely. |
Collaborator
Author
NIC619
approved these changes
Dec 4, 2018
NIC619
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, maybe also update the README file?
|
|
||
| update-go-mod: | ||
| GO111MODULE=on go mod download && go mod tidy | ||
|
|
Collaborator
There was a problem hiding this comment.
We can also remove the gx related commands in Makefile.
Collaborator
Author
There was a problem hiding this comment.
will do those in #125 for better review experience.
Collaborator
Author
mhchia
approved these changes
Dec 4, 2018
mhchia
left a comment
Collaborator
There was a problem hiding this comment.
Tried and it works well! Great work:)
Collaborator
Author
This was referenced Dec 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
make update-go-modWhat was wrong?
go modworks this time./bindirectoryHow was it fixed?
go get -v github.com/libp2p/go-libp2p-crypto@master.Cute Animal Picture