Speed up deletions#981
Open
dratchkov wants to merge 1 commit intoetianen:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two performance issues I encountered with the 'deleterevisions' command:
.distinst()to the query speeds up the process enourmouslyrevisions_to_delete.delete()has the side effect of loading all versions and calling any signals. In my case, this consumed a lot of memory and blew up. I propose to pre-delete all versions using._raw_delete()method. I considered object caches, but since the revisions are deleted with.delete(), any revisions objects will be invalidated, so at worst, anyVersionobjects in the cache will remain inaccessible and get invalidated slowly over time.