Conversation
Fixes #2. Note that this purposely leaves other files intact that contain the same mis-spelling, specifically `cdao-deprecated-mappings.owl`. This is because there the mis-spelling is in the term IRIs for v1.0 CDAO term IRIs. (One example why using term labels as part of term IRIs is can be a bad idea.)
balhoff
approved these changes
Jun 2, 2017
Member
balhoff
left a comment
balhoff
left a comment
There was a problem hiding this comment.
I was going to propose "Jukes–Cantor", but I think that might better be part of a comprehensive normalization of the labels in CDAO, which were automatically migrated from the old camel-case IDs.
Contributor
Author
|
Yes, I had the exact same thought. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2. Note that this purposely leaves other files intact that contain the same mis-spelling, specifically
cdao-deprecated-mappings.owl. This is because there the mis-spelling is in the term IRIs for v1.0 CDAO term IRIs. (One example why using term labels as part of term IRIsis can be a bad idea.)