Allows more complex suffixes in notebooks#328
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
chrisjsewell
left a comment
chrisjsewell
left a comment
There was a problem hiding this comment.
Thanks! One minor thing to change
|
|
||
| def nb_has_all_output(source_path: str, nb_extensions: List[str] = (".ipynb",)) -> bool: | ||
| def nb_has_all_output( | ||
| source_path: str, nb_extensions: Tuple[str] = (".ipynb",) |
There was a problem hiding this comment.
Tuple[str] means a tuple with only one element that is a string. For a variable number use I think Tuple[str,...] or maybe just Iterable[str] would be better
There was a problem hiding this comment.
Indeed. Changed it to Iterable[str] in f17d12c
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 87.42% 87.43%
=======================================
Files 12 12
Lines 1336 1337 +1
=======================================
+ Hits 1168 1169 +1
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Congrats on your first merged pull request in this project! 🎉 |
2 participants
fixes #327
Allows more complex suffixes in
env.nb_allowed_exec_suffixes