`verify-config: current directory is not an exercism folder` when running `factor -run=exercism.testing run-all`

[petertseng]

The setup used:

• Factor: http://downloads.factorcode.org/linux-x86-64/factor-linux-x86-64-2018-01-27-00-50.tar.gz
• Brand-new installation of Arch Linux on Vagrant 2.0.1 using ogarcia/archlinux-x64 2018.01.01: https://app.vagrantup.com/ogarcia/boxes/archlinux-x64
• Exercism directory is /vagrant/exercism/factor and contains the result of running exercism fetch factor hello-world, which means /vagrant/exercism/factor/hello-world contains files:
  • hello-world.factor
  • hello-world-tests.factor
  • README.md

I also attempted to create a ~/.exercism.json that contains {"dir": "/vagrant/exercism"} but its presence or absence makes no difference.

When I run factor -run=exercism.testing run-all while CWD is /vagrant/exercism/factor, this is what happens:

[vagrant@arch factor]$ factor -run=exercism.testing run-all
fatal: Not a git repository (or any parent up to mount point /vagrant/exercism)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
working directory OK: /vagrant/exercism/factor is a user-env 
exercism.testing: verify-config: current directory is not an exercism folder
word verify-config
(U) Quotation: [ c-to-factor => ]
    Word: c-to-factor
(U) Quotation: [ [ (get-catchstack) push ] dip call => (get-catchstack) pop* ]
(O) Word: command-line-startup
(O) Word: choose-exercism-test-suite
(O) Method: M\ POSTPONE: f verify-config
(O) Word: not-an-exercism-folder
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]

Okay, seems to understand that this is a user-env, but I could not determine from https://github.com/catb0t/exercism.factor/blob/master/exercism/config/config.factor how to convince verify-config that this is an exercism folder.

I guess I'll try the other way?

[vagrant@arch factor]$ factor
Factor 0.98 x86.64 (1854, heads/master-f976d97983, Sat Jan 27 00:50:05 2018)
[GCC 5.2.1 20151010] on linux
IN: scratchpad USING: io.directories exercism.testing ;
Loading resource:work/exercism/testing/testing.factor
Loading resource:work/exercism/exercism.factor
Loading resource:basis/http/client/client.factor
Loading resource:basis/http/http.factor
Loading resource:basis/base64/base64.factor
Loading resource:basis/base64/base64-docs.factor
Loading resource:basis/calendar/format/format.factor
Loading resource:basis/calendar/parser/parser.factor
Loading resource:basis/http/parsers/parsers.factor
Loading resource:basis/io/crlf/crlf.factor
Loading resource:basis/io/crlf/crlf-docs.factor
Loading resource:basis/mime/types/types.factor
Loading resource:basis/mime/types/types-docs.factor
Loading resource:basis/http/http-docs.factor
Loading resource:basis/http/client/post-data/post-data.factor
Loading resource:basis/http/client/post-data/post-data-docs.factor
Loading resource:basis/http/client/debugger/debugger.factor
Loading resource:basis/http/client/client-docs.factor
Loading resource:basis/json/json.factor
Loading resource:basis/json/reader/reader.factor
Loading resource:basis/json/reader/reader-docs.factor
Loading resource:basis/json/writer/writer.factor
Loading resource:basis/json/writer/writer-docs.factor
Loading resource:basis/json/json-docs.factor
Loading resource:basis/tools/scaffold/scaffold.factor
Loading resource:basis/tools/scaffold/scaffold-docs.factor
Loading resource:work/exercism/config/config.factor
fatal: Not a git repository (or any parent up to mount point /vagrant/exercism)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
resource:work/exercism/config/config.factor:2: Note:
Already using ``exercism'' vocabulary
working directory OK: /vagrant/exercism/factor is a user-env 
Loading resource:work/exercism/testing/testing-docs.factor
IN: scratchpad "." [ run-all-exercism-tests ] with-directory
exercism.testing: exercises-folder: current directory is not an exercism folder
word exercises-folder

Type :help for debugging help.
IN: scratchpad "/vagrant/exercism/factor" [ run-all-exercism-tests ] with-directory
exercism.testing: exercises-folder: current directory is not an exercism folder
word exercises-folder

Type :help for debugging help.
IN: scratchpad [vagrant@arch factor]

Well, guess I'm out of options for now. I will try again later if I gain more knowledge and therefore understand how to convince verify-config that this is in fact an exercism folder. Please excuse me if I lack the time to gain more knowledge in the near few months.

The exact Vagrantfile used:

Vagrant.configure('2') do |config|
  config.vm.box = 'ogarcia/archlinux-x64'
  # not even sure this helps
  config.vm.synced_folder ".", '/vagrant/exercism/factor'

  config.vm.provision 'shell', inline: <<-SHELL
    ln -s /vagrant/exercism/factor /home/vagrant/factor

    # Well, to get exercism.factor we will either have to get git or unzip.
    pacman -Sy --noconfirm rxvt-unicode-terminfo git

    # factor
    # https://github.com/exercism/factor/blob/master/docs/INSTALLATION.md
    # tells us we have to use a nightly build for testing.
    # Well, fine.
    # I get a link from
    # http://builds.factorcode.org/package?os=linux&cpu=x86.64
    curl -o factor.tar.gz http://downloads.factorcode.org/linux-x86-64/factor-linux-x86-64-2018-01-27-00-50.tar.gz
    sudo -u vagrant mkdir -p /home/vagrant/usr
    sudo -u vagrant tar xzf factor.tar.gz -C /home/vagrant/usr
    mv factor.tar.gz /home/vagrant/usr

    # add factor to PATH
    # coreutils installs a factor that factorises numbers.
    # So we will have to put our factor first. It's fine.
    echo 'export PATH=/home/vagrant/usr/factor/:$PATH' >> /home/vagrant/.bashrc

    # exercism.factor
    sudo -u vagrant git clone https://github.com/catb0t/exercism.factor.git
    sudo -u vagrant mkdir -p /home/vagrant/usr/factor/work
    mv exercism.factor/exercism /home/vagrant/usr/factor/work
    rm -rf exercism.factor
  SHELL
end

I plan to close this immediately to signify that I don't really need a response or anything. Feel free to give input whenever, or never.

[petertseng]

title should have verify-config in it. Edited.

[petertseng]

One possible reason: the Vagrantfile and/or .vagrant present in the directory (it's inside /vagrant/exercism/factor) get mistaken as an exercise or something.

[petertseng]

Issue resolved. I apply the following diff:

diff --git a/exercism/config/config.factor b/exercism/config/config.factor
index 80bdf5f..74d5d41 100644
--- a/exercism/config/config.factor
+++ b/exercism/config/config.factor
@@ -43,7 +43,7 @@ M: dev-env exercise>filenames
   { "-tests.factor" "-example.factor" }
   [ append ] with map first2 ;
 
-M: user-env exercise>filenames
+M: f exercise>filenames
   dup prepend-path
   { "-tests.factor" ".factor" } [ append ] with map
   first2 ;
@@ -84,7 +84,7 @@ M: user-env exercise-exists?
   dup exercise>filenames [ exists? ] tri@ and and ;
 
 M: f exercise-exists?
-  drop \ exercise-exists? not-an-exercism-folder ;
+  dup exercise>filenames [ exists? ] tri@ and and ;
 
 
 HOOK: config-exclusive? project-env ( exercises deprecated -- ? )
@@ -157,7 +157,7 @@ M: dev-env verify-config
     print ]
   if ;
 
-M: user-env verify-config
+M: f verify-config
   exercises-folder child-directories
   [ exercise>filenames [ exists? ] bi@ and ] all?
 
@@ -166,9 +166,6 @@ M: user-env verify-config
     print ]
   if ;
 
-M: f verify-config
-  \ verify-config not-an-exercism-folder ;
-
 
 : guess-project-env ( -- env )
   wd-is-user-env? wd-is-dev-env? xor
diff --git a/exercism/exercism.factor b/exercism/exercism.factor
index e938154..5f3cae0 100644
--- a/exercism/exercism.factor
+++ b/exercism/exercism.factor
@@ -81,4 +81,4 @@ M:      not-an-exercism-folder summary
 HOOK: exercises-folder project-env ( -- dirname )
 M: dev-env  exercises-folder  "exercises" ; inline
 M: user-env exercises-folder  "."         ; inline
-M: f        exercises-folder  \ exercises-folder not-an-exercism-folder ;
+M: f        exercises-folder  "."         ; inline
diff --git a/exercism/testing/testing.factor b/exercism/testing/testing.factor
index a8ea57f..fd6db1b 100644
--- a/exercism/testing/testing.factor
+++ b/exercism/testing/testing.factor
@@ -30,8 +30,8 @@ M: user-env handle-name-clash
   (handle-name-clash) ; inline
 
 M: f handle-name-clash
-  drop
-  \ handle-name-clash not-an-exercism-folder ; inline
+  add-vocab-root
+  (handle-name-clash) ; inline
 
 :: (run-exercism-test) ( exercise -- )
   exercise
@@ -55,7 +55,7 @@ M: user-env run-exercism-test
   (run-exercism-test) ;
 
 M: f run-exercism-test
-  drop \ run-exercism-test not-an-exercism-folder ;
+  (run-exercism-test) ;
 
 
 : run-all-exercism-tests ( -- )

And now I can do either of the two following (NOTE that hello-world is expected to fail, since I have it output "Goodbye, world!")

[vagrant@arch factor]$ factor -run=exercism.testing run-all
fatal: Not a git repository (or any parent up to mount point /vagrant/exercism)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
working directory OK: /vagrant/exercism/factor is a user-env 
invalid config: exercises are missing implementations or tests


testing exercise: hello-world

Unit Test: { { "Hello, World!" } [ say-hello ] }
--> test failed!

testing exercise: .vagrant

Unix system call “open” failed:

No such file or directory (2)

It was called with the following arguments:

"/vagrant/exercism/factor/.vagrant/.vagrant.factor"
0
438
(U) Quotation: [ c-to-factor => ]
    Word: c-to-factor
(U) Quotation: [ [ (get-catchstack) push ] dip call => (get-catchstack) pop* ]
(O) Word: command-line-startup
(O) Word: run-all-exercism-tests
(O) Word: (run-exercism-test)
(O) Word: run-file
(O) Word: parse-file
(O) Method: M\ unix (file-reader)
(O) Method: M\ unix open-file
(O) Word: unix-system-call-error
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]

[vagrant@arch factor]$ factor -run=exercism.testing hello-world
fatal: Not a git repository (or any parent up to mount point /vagrant/exercism)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
working directory OK: /vagrant/exercism/factor is a user-env 
invalid config: exercises are missing implementations or tests


testing exercise: hello-world

Unit Test: { { "Hello, World!" } [ say-hello ] }
--> test failed!

And of course, if we change hello-world to give the correct output, I won't bore everyone with the run-all output again, but:

[vagrant@arch factor]$ factor -run=exercism.testing hello-world
fatal: Not a git repository (or any parent up to mount point /vagrant/exercism)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
working directory OK: /vagrant/exercism/factor is a user-env 
invalid config: exercises are missing implementations or tests


testing exercise: hello-world

Unit Test: { { "Hello, World!" } [ say-hello ] }

Fantastic.

[petertseng]

To recap, here is the working Vagrantfile:

# -*- mode: ruby -*-
# vi: set ft=ruby :
Vagrant.configure('2') do |config|
  config.vm.box = 'ogarcia/archlinux-x64'

  config.vm.provision 'shell', inline: <<-SHELL
    ln -s /vagrant /home/vagrant/factor

    # Well, to get exercism.factor we will either have to get git or unzip.
    pacman -Sy --noconfirm rxvt-unicode-terminfo git

    # factor
    # https://github.com/exercism/factor/blob/master/docs/INSTALLATION.md
    # tells us we have to use a nightly build for testing.
    # Well, fine.
    # I get a link from
    # http://builds.factorcode.org/package?os=linux&cpu=x86.64
    curl --silent -o factor.tar.gz http://downloads.factorcode.org/linux-x86-64/factor-linux-x86-64-2018-01-27-00-50.tar.gz
    sudo -u vagrant mkdir -p /home/vagrant/usr
    sudo -u vagrant tar xzf factor.tar.gz -C /home/vagrant/usr
    mv factor.tar.gz /home/vagrant/usr

    # add factor to PATH
    # coreutils installs a factor that factorises numbers.
    # So we will have to put our factor first. It's fine.
    echo 'export PATH=/home/vagrant/usr/factor/:$PATH' >> /home/vagrant/.bashrc

    # exercism.factor
    sudo -u vagrant git clone https://github.com/catb0t/exercism.factor.git
    sudo -u vagrant mkdir -p /home/vagrant/usr/factor/work
    # Apply patch to allow /vagrant instead of requiring /vagrant/exercism/factor,
    # and to deal with the presence of .vagrant (which would falsely get detected as an exercise)
    (cd exercism.factor && git apply /vagrant/exercism.factor.patch)
    mv exercism.factor/exercism /home/vagrant/usr/factor/work
    rm -rf exercism.factor
  SHELL
end

With the patch described in previous comment in exercism.factor.patch.

As I now have a known-working setup, there is no further input necessary on this issue.

[catb0t]

Sorry, but I'm not applying a patch which uses null (f) in the place of important values -- With all due respect, your patch is a hack which teeters on the edge of working.

I need to work on re-writing the entire exercism vocabulary to avoid global state, but in my opinion you shouldn't have a file called .vagrant.factor, because a file by that name should be a Factor source file.

[petertseng]

your patch is a hack which teeters on the edge of working.

exactly!

shouldn't have a file called .vagrant.factor

agreed; such a file would appear to be Factor code.

I am not aware of the presence of such a file currently.