Fix description for random key in SimpleCipher#917
Merged
mk-mxp merged 2 commits intoexercism:mainfrom Aug 27, 2025
Merged
Conversation
The tests expect the key to only contain lowercase letters, but the instructions for generating a random key say to use alphanumeric characters.
Contributor
|
Hi @IsaacUtah1379, this exercise needs to be synchronised to the common problem-specifications. Doing so will improve the description in many ways. Are you willing to amend your Pull Request to update the whole file and add even more value to it? |
mk-mxp
added
x:action/sync
Contributor
Author
|
I'd be happy to! Is there anything special I need to do, or should I just copy the description from problem-specifications over to the instructions.md file? |
Contributor
|
@IsaacUtah1379 please simply copy the instructions. |
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests in SimpleCipher expect the key to only contain lowercase letters, but the instructions for generating a random key say to use alphanumeric characters.