Ozan's Playlist concept exercise#435
Conversation
|
Delighted to see that CI passes, for the first time since the test runner update. |
Yep!
No R test runner updates yet (a couple for Julia's yesterday). I've made good headway with R's though and I'm trying to work out the details and corner cases. I've decided to try to write the test processing bit in R, so future maintainers can modify it without knowing Bash. This is proving troublesome though since there's no I'll try to get to reviewing here tonight, but I'm at about max levels of obsession with the test runner, so I can't make any promises. |
If we need a small package like |
depial
left a comment
depial
left a comment
There was a problem hiding this comment.
Just one comment on the hints.md which highlights your point about being too specific. I think we're supposed to tend towards the more general, as you suggest, and here I think the exercise is so straightforward specificity is unnecessary anyways.
If you want to add something for Task 1 and Task 2 for completeness, maybe something like:
## 1. Remove duplicate tracks
- Remember that removing duplicates leaves you with the unique entries.
## 2. Check whether a track has already been added
- This is checking for inclusion, which we've already seen in previous concepts.
As long as that doesn't sound to patronizing... :D
| These are all short and simple tasks. | ||
| If you find yourself writing several lines of code in a function, please stop and read the introduction. | ||
|
|
||
| ## 3. Add tracks |
There was a problem hiding this comment.
I don't know if we need to have a complete list (from 1 to 5 here). I would venture a guess that it's not necessary, but that really is just a guess.
There was a problem hiding this comment.
Point noted, but I'm curious to test whether hints need to be numbered consecutively from 1. Is it OK to merge this as-is and see how it looks?
There was a problem hiding this comment.
May as well give it a look to see how the website reacts.
There was a problem hiding this comment.
Seems absolutely fine. I think the Rails backend just looks for level-2 headers (starting with ## ).
|
It looks like the hints button is still available and they pop up with just the name of the task. It might be better to add something... 
|
|
OK, I didn't even know there was a hints button! I was looking under the Get Help tab, which is fine. Looks like we'll be adding hints, though I'm more worried about Mixed Juices timing out. |
|
I'm also getting a time out there... |
|
I'm just about to push a PR with the print function for Task 3. Maybe that will sort something out? |
I think this came with v2 of the test runner :D |
2 participants
A simple one for
set-operations. It's hard to avoid giving too much away in the hints, so I'm sort of tempted to cut it down to just the general advice.Are the tests correctly numbered? I'm still a bit vague about what we agreed.