Added two PartialEq-related tests#1572
Closed
kelleyvanevert wants to merge 1 commit intoexercism:mainfrom
Closed
Conversation
senekor
requested changes
Jul 7, 2023
Contributor
senekor
left a comment
senekor
left a comment
There was a problem hiding this comment.
Looks good!
nit: I would combine these two added tests and call them something like test_unequal_number_of_decimal_places, since the purpose is not to test gt or lt functionality.
senekor
added a commit
that referenced
this pull request
Sep 10, 2023
Contributor
|
superseded by #1726 |
senekor
added a commit
that referenced
this pull request
Sep 11, 2023
senekor
added a commit
that referenced
this pull request
Sep 11, 2023
senekor
added a commit
that referenced
this pull request
Sep 11, 2023
senekor
added a commit
that referenced
this pull request
Sep 11, 2023
senekor
added a commit
that referenced
this pull request
Sep 12, 2023
senekor
added a commit
that referenced
this pull request
Sep 12, 2023
senekor
added a commit
that referenced
this pull request
Sep 12, 2023
senekor
added a commit
that referenced
this pull request
Sep 13, 2023
senekor
added a commit
that referenced
this pull request
Sep 14, 2023
senekor
added a commit
that referenced
this pull request
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a silly implementation I accidentally wrote, I was able to pass all the PartialEq-related tests, even though my implementation didn't actually behave.
My implementation was like a floating point implementation, but with the data in a BigInt, but the floating point was incorrectly used in the PartialEq implementation. These tests test for that kind of mistake, where the number of digits in the decimal expansion determine the behavior of the PartialEq implementation.