low-power-embedded-game: change test order for clarity#1583
Closed
antonmry wants to merge 1 commit intoexercism:mainfrom
antonmry:fix/low-power-embedded-game
Closed
low-power-embedded-game: change test order for clarity#1583antonmry wants to merge 1 commit intoexercism:mainfrom antonmry:fix/low-power-embedded-game
antonmry wants to merge 1 commit intoexercism:mainfrom
antonmry:fix/low-power-embedded-game
Conversation
senekor
approved these changes
Jul 7, 2023
senekor
added a commit
that referenced
this pull request
Sep 10, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
Contributor
|
superseded by #1725 |
senekor
added a commit
that referenced
this pull request
Sep 10, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 11, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 11, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 11, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 12, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 12, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 12, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 13, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 14, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings.
senekor
added a commit
that referenced
this pull request
Sep 15, 2023
Source: #1583 Students may think they have to work with values instead of their position. This confusion can easily be avoided if the first test uses strings. [no important files changed]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this exercise, it's easy to think you must work with values instead of their position. The README only states it in the title:
And the first tests are about sequences of numbers, so it makes sense. I wasn't the only one who made that mistake:
https://stackoverflow.com/a/71145392
https://stackoverflow.com/questions/69032551/in-rust-how-can-i-restrict-a-generic-t-to-allow-modulus
I propose to change the order of tests, so the test with strings is first. This should be easy, and it doesn't add more tests.