Skip to content

parallel-letter-frequency: Sync tests & add missing #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellnix merged 9 commits into from
Mar 9, 2025
Merged

parallel-letter-frequency: Sync tests & add missing #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d9f5fb9
parallel-letter-frequency: Sync tests & add missing
ellnix Mar 3, 2025
35ca8ca
parallel-letter-frequency: Rename tests to match problem-specifications
ellnix Mar 9, 2025
a73b6f6
parallel-letter-frequency: Add test function names
ellnix Mar 9, 2025
790d0fc
parallel-letter-frequency: Add missing tests
ellnix Mar 9, 2025
a8da3f1
parallel-letter-frequency: Fix typo in test
ellnix Mar 9, 2025
7939dbd
parallel-letter-frequency: Replace vec with array
ellnix Mar 9, 2025
9b3791e
parallel-letter-frequency: Add "Unicode letters" test
ellnix Mar 9, 2025
50d0072
parallel-letter-frequency: Run rustfmt
ellnix Mar 9, 2025
4d0bcfc
parallel-letter-frequency: Move inputs under tests
ellnix Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions exercises/practice/parallel-letter-frequency/.meta/tests.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# This is an auto-generated file.
#
# Regenerating this file via `configlet sync` will:
# - Recreate every `description` key/value pair
# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
# - Preserve any other key/value pair
#
# As user-added comments (using the # character) will be removed when this file
# is regenerated, comments can be added via a `comment` key.

[c054d642-c1fa-4234-8007-9339f2337886]
description = "no texts"

Comment thread
senekor marked this conversation as resolved.
[818031be-49dc-4675-b2f9-c4047f638a2a]
description = "one text with one letter"

[c0b81d1b-940d-4cea-9f49-8445c69c17ae]
description = "one text with multiple letters"

[708ff1e0-f14a-43fd-adb5-e76750dcf108]
description = "two texts with one letter"

[1b5c28bb-4619-4c9d-8db9-a4bb9c3bdca0]
description = "two texts with multiple letters"

[6366e2b8-b84c-4334-a047-03a00a656d63]
description = "ignore letter casing"
rust_fn = "case_insensitivity"

[92ebcbb0-9181-4421-a784-f6f5aa79f75b]
description = "ignore whitespace"

[bc5f4203-00ce-4acc-a5fa-f7b865376fd9]
description = "ignore punctuation"
rust_fn = "punctuation_doesnt_count"

[68032b8b-346b-4389-a380-e397618f6831]
description = "ignore numbers"
rust_fn = "numbers_dont_count"

[aa9f97ac-3961-4af1-88e7-6efed1bfddfd]
description = "Unicode letters"

[7b1da046-701b-41fc-813e-dcfb5ee51813]
description = "combination of lower- and uppercase letters, punctuation and white space"
rust_fn = "all_three_anthems_1_worker"
Comment on lines +45 to +47
Copy link
Copy Markdown
Contributor Author

@ellnix ellnix Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt it was appropriate to match tests based on the behavior under test, not necessarily the exact content of the input.

Copy link
Copy Markdown
Contributor Author

@ellnix ellnix Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the input of "combination of lower- and uppercase letters, punctuation and white space" is this:

      "input": {
        "texts": [
          "There, peeping among the cloud-wrack above a dark tower high up in the mountains, Sam saw a white star twinkle for a while. The beauty of it smote his heart, as he looked up out of the forsaken land, and hope returned to him. For like a shaft, clear and cold, the thought pierced him that in the end, the shadow was only a small and passing thing: there was light and high beauty forever beyond its reach."
        ]
      },

Copy link
Copy Markdown
Contributor

@senekor senekor Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. If we're maintaining the tests manually, we might as well grant ourselves the flexibility a template would lack. Behavior is what counts.


[4727f020-df62-4dcf-99b2-a6e58319cb4f]
description = "large texts"

[adf8e57b-8e54-4483-b6b8-8b32c115884c]
description = "many small texts"
rust_fn = "many_times_same_text"
Loading
⚡