Skip to content

GitHub Actions use ubuntu-24.04, remove unused jobs#124

Merged
keiravillekode merged 4 commits intoexercism:mainfrom
keiravillekode:ubuntu-24
Jun 25, 2025
Merged

GitHub Actions use ubuntu-24.04, remove unused jobs#124
keiravillekode merged 4 commits intoexercism:mainfrom
keiravillekode:ubuntu-24

Conversation

@keiravillekode
Copy link
Copy Markdown
Contributor

@keiravillekode keiravillekode commented Jun 25, 2025

We no longer use dockle or actionlint

@keiravillekode keiravillekode requested a review from a team as a code owner June 25, 2025 07:02
with:
dockerfile: Dockerfile

dockle:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This drops a job, not just changing the image. Is this intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the job was already failing in November. No other tracks are using dockle.

@IsaacG IsaacG changed the title GitHub Actions use ubuntu-24.04 GitHub Actions use ubuntu-24.04, remove unused jobs Jun 25, 2025
@keiravillekode
Copy link
Copy Markdown
Contributor Author

Here are failure reports from the now-removed jobs

https://github.com/exercism/zig-test-runner/actions/runs/15869613435/job/44743026719?pr=124
actionlint

Run /home/runner/work/zig-test-runner/zig-test-runner/actionlint -color
.github/workflows/actionlint.yml:6:14: label "ubuntu-24.04" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
  |
6 |     runs-on: ubuntu-24.04
  |              ^~~~~~~~~~~~

https://github.com/exercism/zig-test-runner/actions/runs/15869613438/job/44743026749?pr=124
dockle

Run goodwithtech/dockle-action@11c82d478fec09ed1aa56d933eab25218e22bb90
/usr/bin/docker run --name ad1f5382c967ee66cc4c079fc5fdb6d074c37f_655985 --label ad1f53 --workdir /github/workspace --rm -e "INPUT_IMAGE" -e "INPUT_FORMAT" -e "INPUT_EXIT-CODE" -e "INPUT_EXIT-LEVEL" -e "INPUT_ACCEPT-KEY" -e "INPUT_OUTPUT" -e "INPUT_IGNORE" -e "INPUT_ACCEPT-FILE" -e "INPUT_ACCEPT-FILE-EXTENSION" -e "INPUT_SENSITIVE-WORD" -e "INPUT_QUIET" -e "INPUT_NO-COLOR" -e "INPUT_TIMEOUT" -e "INPUT_USE-XDG" -e "INPUT_HOST" -e "INPUT_AUTHURL" -e "INPUT_USERNAME" -e "INPUT_PASSWORD" -e "INPUT_INSECURE" -e "DOCKLE_IGNORES" -e "DOCKLE_ACCEPT_KEYS" -e "DOCKLE_REJECT_KEYS" -e "DOCKLE_ACCEPT_FILES" -e "DOCKLE_ACCEPT_FILE_EXTENSIONS" -e "NO_COLOR" -e "DOCKLE_VERSION_CHECK" -e "DOCKLE_TIMEOUT" -e "USE_XDG" -e "DOCKLE_HOST" -e "DOCKLE_AUTH_URL" -e "DOCKLE_USERNAME" -e "DOCKLE_PASSWORD" -e "DOCKLE_INSECURE" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/zig-test-runner/zig-test-runner":"/github/workspace" ad1f53:82c967ee66cc4c079fc5fdb6d074c37f  "-t built-image:scan" "-c 1" "-l warn" "-f list" "-o "
+ getopts :t:c:l:o:f: o
+ export 'imageName= built-image:scan'
+ getopts :t:c:l:o:f: o
+ export 'exitCode= 1'
+ getopts :t:c:l:o:f: o
+ export 'exitLevel= warn'
+ getopts :t:c:l:o:f: o
+ export 'format= list'
+ getopts :t:c:l:o:f: o
+ export 'output= '
+ getopts :t:c:l:o:f: o
+ FIRST_ARGS=
+ SECOND_ARGS=
+ '[' warn ]
+ FIRST_ARGS=' --exit-level  warn'
+ SECOND_ARGS=' --exit-level  warn'
+ '[' list ]
+ FIRST_ARGS=' --exit-level  warn --format  list'
+ '[' ]
+ '[' 1 ]
+ SECOND_ARGS=' --exit-level  warn --exit-code  1'
+ RUN_TWICE=
+ '[' ' ' '!='  ]
+ '[' ' 1' '!=' 0 ]
+ RUN_TWICE=TRUE
+ '[' TRUE ]
+ run_dockle --exit-level warn --format list
+ /usr/bin/dockle --exit-level warn --format list built-image:scan
2025-06-25T07:02:45.317Z    FATAL   unable to initialize a image struct: failed to initialize source: reading manifest scan in docker.io/library/built-image: requested access to the resource is denied

actionlint, like dockle, is not being used by other test runners.

@keiravillekode keiravillekode merged commit 00c3eab into exercism:main Jun 25, 2025
3 checks passed
@keiravillekode keiravillekode deleted the ubuntu-24 branch June 25, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants